Skip to content

Enhance the handling of Union types in HfArgumentParser #41441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyyever wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enhance the handling of Union types in HfArgumentParser #41441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42c6e09
Simplify handling of Union types in HfArgumentParser
cyyever Oct 8, 2025
bc8efee
Improve Union type handling in HfArgumentParser
cyyever May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/transformers/hf_argparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,10 @@ def _parse_dataclass_field(parser: ArgumentParser, field: dataclasses.Field):
origin_type = getattr(field.type, "__origin__", field.type)
elif bool not in field.type.__args__:
# filter `NoneType` in Union (except for `Union[bool, NoneType]`)
field.type = (
field.type.__args__[0] if isinstance(None, field.type.__args__[1]) else field.type.__args__[1]
)
if str in field.type.__args__ and len(field.type.__args__) > 2:
field.type = str
else:
field.type = next(arg for arg in field.type.__args__ if arg is not type(None))
origin_type = getattr(field.type, "__origin__", field.type)

# A variable to store kwargs for a boolean field, if needed
Expand Down
Loading