Skip to content

🌐 [i18n-KO] Translated selecting.md to Korean - #41527

Closed
maximizemaxwell wants to merge 3 commits into
huggingface:mainfrom
maximizemaxwell:ko-selecting.md
Closed

maximizemaxwell wants to merge 3 commits into
huggingface:mainfrom
maximizemaxwell:ko-selecting.md

Conversation

@maximizemaxwell

Copy link
Copy Markdown
Contributor

What does this PR do?

Translated the selecting.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?
@4N3MONE, @yijun-lee, @jungnerd , @harheem

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@maximizemaxwell
maximizemaxwell marked this pull request as draft October 12, 2025 03:33
@4N3MONE

4N3MONE commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

LGTM! 가능하다면 테이블 안의 텍스트에서는 .(온점)을 빼는게 나을 것 같기는 합니다..!

@ArthurZucker

Copy link
Copy Markdown
Collaborator

Thanks for the PR, and sorry it didn't make it in! This branch is based on v4, and v5 is very different, so rather than rebasing we'd love to invite you to open a new PR against main using our latest tools and good practices:

Closing this one in the meantime, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants