Skip to content

Update modeling_llama4.py #41557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alfredo-etched wants to merge 2 commits into from
Closed

Update modeling_llama4.py #41557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e4fbc5
Update modeling_llama4.py
alfredo-etched Oct 14, 2025
8e878ce
Merge branch 'main' into patch-1
alfredo-etched Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/models/llama4/modeling_llama4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def forward(self, x):
return self.down_proj(down_proj)


class Llama4TextL2Norm(torch.nn.Module):
class Llama4TextL2Norm(torch.nn.Module): # Does the LLAMA4 specification require RMSNorm or L2Norm? Because this is RMSnorm, not L2Norm, despite its naming.
def __init__(self, eps: float = 1e-6):
super().__init__()
self.eps = eps
Expand Down