-
Notifications
You must be signed in to change notification settings - Fork 31.7k
revert changes in _is_package_available #41891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vasqu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the same applies to FA3 for example 😢
|
I think in FA3 we do have loaders |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Nope, just checked. Spec is there, loader is None Have it locally installed |
|
they don't have an |
BenjaminBossan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the original issue, thanks for the quick action.
|
They do, but they don't make it as an importable function as per the pkg name --> "flash_attn_3" is not importable and the loader check fails here. |
|
I'm not sure what you mean @vasqu, for example here, just creating the |
* update * rm comment
What does this PR do?
Reverts #41411, because for some packages like
optimumwe don't have loaders as expected from most packages.