Fix UnboundLocalError in RT-DETR loss computation #42224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocketknight1
approved these changes
Nov 17, 2025
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Yep, fix LGTM! Not sure how often this path is taken, but worth fixing regardless.
Rocketknight1
force-pushed
the
fix-rtdetr-auxiliary-loss-clean
branch
from
145451a to
a359a4d
Compare
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Rocketknight1
force-pushed
the
fix-rtdetr-auxiliary-loss-clean
branch
2 times, most recently
from
cd8d1f5 to
1426ea5
Compare
Initialize auxiliary_outputs to None before conditional use to prevent UnboundLocalError when config.auxiliary_loss is False. Fixes the error: UnboundLocalError: local variable 'auxiliary_outputs' referenced before assignment This occurs when auxiliary_loss is disabled but the variable is still referenced later in the function.
Rocketknight1
force-pushed
the
fix-rtdetr-auxiliary-loss-clean
branch
from
1426ea5 to
c208f1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an
UnboundLocalErrorthat occurs in the RT-DETR loss computation whenconfig.auxiliary_lossisFalse.Problem
The variable
auxiliary_outputsis conditionally assigned inside anif config.auxiliary_loss:block, but it's referenced later in the function regardless of whether the condition was true. Whenauxiliary_lossis disabled, this causes:Solution
Initialize
auxiliary_outputs = Nonebefore the conditional block to ensure it's always defined before use.Changes
auxiliary_outputs = Noneinitialization insrc/transformers/loss/loss_rt_detr.py:450Testing
This fix ensures the function works correctly whether
config.auxiliary_lossisTrueorFalse.