Repository navigation
Remove generic output_attentions warning - #42333
Closed
Aravind-11 wants to merge 37 commits into
Closed
Aravind-11 wants to merge 37 commits into
Aravind-11 wants to merge 37 commits into
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: owlvit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the overly broad generic warning for
output_attentions=Truethat was added in #40597. This warning incorrectly flagged customAttentionInterfacebackends that properly return attention weights.Fixes #41924
Changes
Removed from
src/transformers/utils/generic.py(lines ~1013-1025):Before submitting
Pull Request section?
to it if that's the case.
Who can review?