Skip to content

handle get_input_embeddings() on models like gemma3 gracefully #42542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
winglian wants to merge 1 commit into from
Closed

handle get_input_embeddings() on models like gemma3 gracefully #42542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/transformers/modeling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1983,7 +1983,11 @@ def make_inputs_require_grads(module, input, output):
if not (isinstance(module, PreTrainedModel) and hasattr(module, "get_input_embeddings")):
continue

input_embeddings = module.get_input_embeddings()
try:
input_embeddings = module.get_input_embeddings()
except NotImplementedError:
# handle submodules such as siglip which don't have this implemented
input_embeddings = None

if input_embeddings is None:
continue
Expand Down