Repository navigation
Conversation
Collaborator
|
thanks! tho we don't really maintain these anymore! @merveenoyan do you want to merge? |
RinZ27
force-pushed
the
perf/pin-memory-v2
branch
2 times, most recently
from
January 10, 2026 09:59
cc523c8 to
c3de0e0
Compare
Author
|
Hi @ArthurZucker, thanks for the response. @merveenoyan, just checking in to see if you have any thoughts on merging this. It's a small change but would be beneficial for anyone still using these examples for reference. Thanks! |
RinZ27
force-pushed
the
perf/pin-memory-v2
branch
6 times, most recently
from
January 15, 2026 06:48
8bdb659 to
c272c99
Compare
RinZ27
force-pushed
the
perf/pin-memory-v2
branch
from
January 20, 2026 15:34
c272c99 to
07bb743
Compare
RinZ27
force-pushed
the
perf/pin-memory-v2
branch
from
January 20, 2026 15:43
07bb743 to
4732151
Compare
Author
|
I've squashed the commits into a single clean one and ensured the |
Collaborator
|
We removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
pin_memory=Truein theDataLoaderfor the causal language modeling standalone example.Pinned memory is a PyTorch best practice that improves host-to-device transfer efficiency.