[CB] Ensure parallel decoding test passes using FA#43277
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
approved these changes
Jan 14, 2026
Contributor
vasqu
left a comment
There was a problem hiding this comment.
Thx also double checked locally, works 👍
| # with torch 2.9. This might be due to a GPU diff, so test might be flaky on the CI which runs on A10. | ||
| @parameterized.expand([True, False]) | ||
| @require_torch_accelerator | ||
| @require_flash_attn # otherwise the test can fail because attention bias has a very slight impact on SDPA and eager |
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
Ensure parallel decoding matches using FA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaky test in continuous batching: the test was checking two streams of parallel decoding matched, but used
sdpaas the attention implementation. Butsdpais not batch invariant, so despite a well formed attention mask, the test failed. With flash-attention, it is not the case anymore. It tested the following snippet:and the number of failure for each implementation was:
sdpa: 597eager: 156kernels-community/flash-attn: 0So I went with flash attention for the test.