Skip to content

refactor output tracing in mamba - #44003

Closed
omkar-334 wants to merge 3 commits into
huggingface:mainfrom
omkar-334:refactor-mamba
Closed

omkar-334 wants to merge 3 commits into
huggingface:mainfrom
omkar-334:refactor-mamba

Conversation

@omkar-334

Copy link
Copy Markdown
Contributor

This PR refactors the mamba model as per #43979

cc @molbap
Screenshot 2026-02-15 at 5 12 43 AM

Note - Only 46 tests were passing initially, the rest were failing due to TypeError: 'int' object is not iterable in SpecifierSet. I examined this and found out this is because of the library - "kernels>=0.10.2,<0.11". When i upgraded this library, all tests pass. The latest version is -
Screenshot 2026-02-15 at 5 15 46 AM
Should we update setup.py?

@github-actions

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: falcon_mamba, mamba

@omkar-334

Copy link
Copy Markdown
Contributor Author

@molbap - here I think falconmamba is copied from make fix-repo. What is the general convention - do we include the overwritten falconmamba over here itself, or do we merge without it and then focus on falconmamba in its own pr?

@ArthurZucker

Copy link
Copy Markdown
Collaborator

Thanks for picking this up from #43979! That call to contributions has been closed, and the reference refactor (#43590) landed afterwards with a slightly different pattern, so this branch is out of date and I'm closing it. If you'd still like to migrate Mamba/FalconMamba, a fresh PR following #43590 (regenerating copies with make fix-repo) is welcome.

@omkar-334 omkar-334 mentioned this pull request Oct 24, 2026
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants