Repository navigation
Conversation
molbap
reviewed
Feb 16, 2026
Comment on lines
546
to
547
| output_attentions=output_attentions, | ||
| output_hidden_states=output_hidden_states, |
Collaborator
There was a problem hiding this comment.
Thanks for the contrib!
Here and everywhere in the modeling file,, output_attentions and output_hidden_states should not be explicitly mentioned anywhere anymore,capture_outputs ought to be added instead.
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: dpr |
This was referenced Apr 29, 2026
Collaborator
|
Thanks for picking this up @omkar-334! The #43979 call for contributions has since been closed and this PR never got reviewed before falling behind main, so I'm closing it. Sorry it didn't land! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
dprmodel as per #43979cc @molbap
