Repository navigation
Fix missing BPE token conversion step in Chameleon - #44582
Merged
Merged
Conversation
yonigozlan
force-pushed
the
fix-chameleon
branch
from
March 10, 2026 21:00
e5c097f to
538453a
Compare
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: chameleon |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hmellor
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix an issue introduced in #42564 . The refactor embedded raw image tokens instead of BPE tokens, causing the model to output gibberish. This fix adds back the image tokens to BPE tokens conversion before embedding.
Cc @hmellor @zucchini-nlp