Skip to content

Fix WeightConverter substring match on leaf-style source patterns #45794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qgallouedec wants to merge 1 commit into from
Closed

Fix WeightConverter substring match on leaf-style source patterns #45794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/transformers/core_model_loading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,6 +655,12 @@ def __init__(self, source_patterns: str | list[str], target_patterns: str | list
for i, source_pattern in enumerate(self.source_patterns):
group_name = f"g{i}"
pattern = source_pattern.replace(".*.", r"\..*\.")
# Auto-anchor leaf-style patterns (those ending with an identifier char) at a key
# boundary, so e.g. ``experts.gate_up_proj`` does not also match
# ``experts.gate_up_proj_scale_inv``. Skip patterns that already end in an explicit
# anchor (``$``) or that intentionally end on a separator (``\.``) for prefix renames.
if pattern and (pattern[-1].isalnum() or pattern[-1] == "_"):
pattern = f"{pattern}(?=$|\\.)"
Comment on lines +658 to +663

@zucchini-nlp zucchini-nlp May 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo we should allow it in case models need to replace anything that starts with "prefix", and the issue is in the regex of MoE in conversion mapping. We need to add an explicit /. in regex instead

in any case cc @Cyrilvallez to decide on it

@ArthurZucker ArthurZucker May 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah and probably error out? this is a good example where there's inteded vs not intended and we should probably not I think assume user wants one of the two

branches.append(f"(?P<{group_name}>{pattern})")
self.compiled_sources = re.compile("|".join(branches))

Expand Down
Loading