Repository navigation
Fix loading with only 1 device or distributed config - #46197
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
changed the title
Cyrilvallez
commented
May 25, 2026
Comment on lines
-4910
to
+4915
| for tied_param in self.all_tied_weights_keys.keys(): | ||
| for tied_param in getattr(self, "all_tied_weights_keys", {}).keys(): |
Member
Author
There was a problem hiding this comment.
Unrelated but this was there for a very good reason, i.e. remote code
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=46197&sha=796937 |
ArthurZucker
approved these changes
May 25, 2026
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
let's add a remote code test!
kaixuanliu
pushed a commit
to kaixuanliu/transformers
that referenced
this pull request
May 28, 2026
* fix * fix * use rank * fix
yuchenxie4645
pushed a commit
to yuchenxie4645/transformers
that referenced
this pull request
May 28, 2026
* fix * fix * use rank * fix
kashif
pushed a commit
to kashif/transformers
that referenced
this pull request
Jun 1, 2026
* fix * fix * use rank * fix
khushali9
pushed a commit
to khushali9/transformers
that referenced
this pull request
Jun 8, 2026
* fix * fix * use rank * fix
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Jul 30, 2026
* fix * fix * use rank * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supersedes #46116. Some params will never go on the correct device if the
device_mapis not set correctly, even with distributed calls (e.g. all non-persistent buffers). This has changed in #45028 but should not have (setting the device only incore_model_loading.pyto load the param is not enough, as non-persistent buffers are not part of the state_dict).This is because we want to put directly everything on the correct device, INCLUDING non persistent buffers.