Repository navigation
Fix kosmos - #48853
Fix kosmos#48853
Conversation
|
[For maintainers] Suggested jobs to run (before merge) run-slow: kosmos2 |
CI recapDashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@askserge review |
|
run-slow: kosmos2 |
Nvidia CIThis comment contains models: ["models/kosmos2"] |
AMD CIThis comment contains models: ["models/kosmos2"] |
|
Would still love to have a short comment, even just like " ... because A bit of context is always good, and you can even let the agent to write that short comment for you 🙏 |
|
|
CI Results (Nvidia)Commit Info
Model CI Report❌ 1 new failed tests from this PR 😭
|
IMO it really does not warrant one, there are many many ways of getting those values, input_ids being the most obvious one IMO, and saying "we don't use mask because X" is super weird for future people reading the code, as the code actually does not touch the mask haha |
What does this PR do?
As per the title. Small fix after #48814 because the mask can now be None sometimes if no padding