Skip to content

Fix kosmos - #48853

Merged
Cyrilvallez merged 2 commits into
mainfrom
fix-kosmos
Sep 16, 2026
Merged

Cyrilvallez merged 2 commits into
mainfrom
fix-kosmos

Conversation

@Cyrilvallez

@Cyrilvallez Cyrilvallez commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

CPU CI GPU run-slow

What does this PR do?

As per the title. Small fix after #48814 because the mask can now be None sometimes if no padding

@github-actions

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: kosmos2

@github-actions

Copy link
Copy Markdown
Contributor

CI recap

Dashboard: View test results in Grafana
Latest run: 35062783818:1
Result: success | Jobs: 5 | Tests: 345 | Failures: 0 | Duration: 3m 0s

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh

ydshieh commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

@askserge review

@ydshieh

ydshieh commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

run-slow: kosmos2

@github-actions

Copy link
Copy Markdown
Contributor

Nvidia CI

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs on Nvidia:

models: ["models/kosmos2"]
quantizations: []

@github-actions

Copy link
Copy Markdown
Contributor

AMD CI

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs on AMD:

models: ["models/kosmos2"]

@ydshieh

ydshieh commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Would still love to have a short comment, even just like " ... because attention_mask is dropped earlier ..." etc, or like a failing tset with error.

A bit of context is always good, and you can even let the agent to write that short comment for you 🙏

@sergereview

sergereview Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

⚠️ Serge review failed: LLM endpoint returned 500 Internal Server Error: {"error":"Internal Error - We're working hard to fix this as soon as possible!"}

@github-actions

Copy link
Copy Markdown
Contributor

CI Results (AMD)

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 6ee8e983 workflow commit (merge commit)
PR fe5d7819 branch commit (from PR)
main 51b330bb base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@github-actions

Copy link
Copy Markdown
Contributor

CI Results (Nvidia)

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 6ee8e983 workflow commit (merge commit)
PR fe5d7819 branch commit (from PR)
main 51b330bb base commit (on main)

Model CI Report

❌ 1 new failed tests from this PR 😭

  • kosmos2:
    tests/models/kosmos2/test_modeling_kosmos2.py::Kosmos2ModelIntegrationTest::test_snowman_image_captioning (❌ ⟹ ❌)

@Cyrilvallez

Cyrilvallez commented Sep 16, 2026 •

Copy link
Copy Markdown
Member Author

Would still love to have a short comment

IMO it really does not warrant one, there are many many ways of getting those values, input_ids being the most obvious one IMO, and saying "we don't use mask because X" is super weird for future people reading the code, as the code actually does not touch the mask haha

@Cyrilvallez
Cyrilvallez merged commit 947d6b4 into main Sep 16, 2026
38 of 39 checks passed
@Cyrilvallez
Cyrilvallez deleted the fix-kosmos branch September 16, 2026 09:46
sbucaille pushed a commit to sbucaille/transformers that referenced this pull request Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants