Repository navigation
Finegrained kernels: unified quantization kernels api (separate quantizers) #49015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
IlyasMoutawwakil
wants to merge
75
commits into
main
Choose a base branch
from
finegrained-per-scheme-demo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
64708a2
finegrained kernels
IlyasMoutawwakil 7b21bdb
deepgemm and tp/ep fixes
IlyasMoutawwakil 05bd0f3
finegrained: adopt the interleaved gate|up layout
IlyasMoutawwakil 686238e
finegrained: keep DeepGEMM Mega MoE on the stacked gate|up layout
IlyasMoutawwakil 641fcb2
fix
IlyasMoutawwakil e6b20c4
Merge remote-tracking branch 'origin/main' into finegrained-unified
IlyasMoutawwakil cb04cbe
finegrained: build the per-call kernel objects instead of caching them
IlyasMoutawwakil e1c7a92
finegrained: fuse both MoE biases into the GEMMs
IlyasMoutawwakil 0a1b49b
Merge origin/main into finegrained-unified
IlyasMoutawwakil 9041320
Merge remote-tracking branch 'origin/main' into finegrained-unified
IlyasMoutawwakil eac0ee8
finegrained: expert layouts as conversion ops; experts forwards on th…
IlyasMoutawwakil 1d94e55
style
IlyasMoutawwakil fb16472
finegrained: on-the-fly quantization for every format; loader keeps c…
IlyasMoutawwakil 07dae50
finegrained: pass input_recipe to the dispatchers, drop the Quantizat…
IlyasMoutawwakil 0b6ca4c
Revert "finegrained: pass input_recipe to the dispatchers, drop the Q…
IlyasMoutawwakil 513e231
finegrained: pass activation_format straight through; let deep-gemm s…
IlyasMoutawwakil 240abc9
hub_kernels: finegrained-kernels ships as version 0
IlyasMoutawwakil 30ab2c2
hub_kernels: load finegrained-kernels from the kernels-staging build …
IlyasMoutawwakil a562fb8
finegrained: consume modelopt's calibrated globals, and fuse a model'…
IlyasMoutawwakil 89267bf
finegrained: address the integration review
IlyasMoutawwakil 09ea21c
finegrained: freeze the mxfp4 and nvfp4 integrations, and serve what …
IlyasMoutawwakil d59f903
Merge branch 'main' into finegrained-unified
IlyasMoutawwakil e139d2a
fix style
IlyasMoutawwakil c665644
FineGrainedFP8Config is its own class again, not an alias of the new one
IlyasMoutawwakil 29cca04
FineGrainedFP8Config: drop the frozen-notice docstring line
IlyasMoutawwakil f63ad97
Tolerate an experts module without the norm, and a machine without CUDA
IlyasMoutawwakil 1265f0c
Pin that every modelopt converter target is a slot the module holds
IlyasMoutawwakil 97dfa10
is_sm100: answer False without CUDA, and fake both halves in the tests
IlyasMoutawwakil 788d02d
fix
IlyasMoutawwakil 53a8970
finegrained: drop the DTensor unwrap, and pass the kernel operands by…
IlyasMoutawwakil e8e6b87
deepgemm: only Mega MoE cannot apply a post-expert norm
IlyasMoutawwakil 43b9a74
Shard quantized expert companions under EP and TP
IlyasMoutawwakil fe0b718
fixes for the new model
IlyasMoutawwakil 22b1001
fix multimodal and add some testing
IlyasMoutawwakil f9302cc
static
IlyasMoutawwakil daa2420
Load a calibrated checkpoint's input_scale, and fix what per-tensor w…
IlyasMoutawwakil b4dcb7b
fix
IlyasMoutawwakil f7081ec
Finish the finegrained integration: reload, TP sharding, dsv4 norms
IlyasMoutawwakil 9ddb214
Fix a destructive Qwen3 TP-plan override; split out the conversions
IlyasMoutawwakil e83eadf
Collapse the conversion-op boilerplate; shorten the longest units
IlyasMoutawwakil 60f904e
Key on capability not name; drop the last op boilerplate
IlyasMoutawwakil 4cb5d9c
Quantize per module group; split the arms by producer, not by format
IlyasMoutawwakil a67e7ac
Carry the quantized-load fixes onto the per-scheme arms, and the same…
IlyasMoutawwakil 9fc683d
Address the per-scheme review
IlyasMoutawwakil 95b3e44
trim
IlyasMoutawwakil 2392e6a
fixes
IlyasMoutawwakil f7a8e54
last
IlyasMoutawwakil 4cbbe7f
Cover the groups feature, and export what it asks callers to build
IlyasMoutawwakil f687860
Point everything at the fine-grained integration; deprecate the froze…
IlyasMoutawwakil fab7f74
Bring two comment blocks under the noisy-comment limits
IlyasMoutawwakil 21c0a07
Bring two comment blocks under the noisy-comment limits
IlyasMoutawwakil 12f5aa8
Do not let the tied-head plan raise in post_init
IlyasMoutawwakil 7abcedf
Do not let the tied-head plan raise in post_init
IlyasMoutawwakil db85a44
Address the second review round
IlyasMoutawwakil d5c361c
Merge finegrained-replace-frozen-fp8 into finegrained-per-scheme-demo
IlyasMoutawwakil 9f7326c
Carry the review's comment and lint fixes to the sites it did not name
IlyasMoutawwakil f1b593d
Make tests/kernels a package so the moved fp8 test can import its fix…
IlyasMoutawwakil 0067189
Declare GLM-4v-MoE's head plan instead of deriving it in the mixin
IlyasMoutawwakil bb24085
cleanup guards and post expert norm in deepgemm
IlyasMoutawwakil 39eb1d1
not now
IlyasMoutawwakil bf0e7ec
minimal peft integration preparation
IlyasMoutawwakil 5b2b7f0
addressing review comments
IlyasMoutawwakil f3c7cc8
Tiny checkpoints for every shipped layout, and the save/load fixes th…
IlyasMoutawwakil 6a7c92e
Keep pre-quantized scale dtypes through the dtype plan
IlyasMoutawwakil 2d1f0bc
Update src/transformers/distributed/sharding_utils.py
IlyasMoutawwakil f37d1d4
Update src/transformers/distributed/sharding_utils.py
IlyasMoutawwakil 5ea2a3e
adapters
IlyasMoutawwakil c766206
Fine-grained layout ops: follow the experts module each tensor fills
IlyasMoutawwakil 7d44b81
Revert "adapters"
IlyasMoutawwakil eb9c09f
trimming
IlyasMoutawwakil 77f135c
Fine-grained NVFP4: exact per-expert gate_up activation globals
IlyasMoutawwakil 71ee044
Merge origin/main into finegrained-per-scheme-demo
IlyasMoutawwakil 4e8aa7e
Fine-grained tests: per-expert gate_up activation globals, and the op…
IlyasMoutawwakil 9620ef5
Merge main into finegrained-per-scheme-demo
IlyasMoutawwakil 585946e
test muse sparknvfp4 after merge
IlyasMoutawwakil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IlyasMoutawwakil marked this conversation as resolved.
Resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.