Skip to content

fix(ci): harden workflow triggers, secrets and gates (#49357) - #49571

Closed
hf-security-analysis[bot] wants to merge 0 commit into
remove-accelerate-examplesfrom
security/workflow-hardening/pr-49357-design
Closed

hf-security-analysis[bot] wants to merge 0 commit into
remove-accelerate-examplesfrom
security/workflow-hardening/pr-49357-design

Conversation

@hf-security-analysis

@hf-security-analysis hf-security-analysis Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Automated hardening of the workflow files flagged on #49357: workflow design only.

Each kind of fix has its own pull request, from a security/workflow-hardening/pr-49357-* branch, and any of them can be merged first: the others are rebuilt on top when this one lands.

Targets remove-accelerate-examples. Files changed, and what changed them:

  • .github/workflows/self-scheduled-amd-mi250-caller.yml — dangerous trigger
  • .github/workflows/self-scheduled-amd-mi300-caller.yml — dangerous trigger
  • .github/workflows/self-scheduled-amd-mi355-caller.yml — dangerous trigger

This does not fix everything. 3 further finding(s) (3 high) need a decision this bot should not make for you. They are in the security channel with their locations — deliberately not repeated here, since this repository may be public and they are not fixed yet.

These changes were generated by Claude — read them before merging.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution 🤗!

CI Security Gate — automatic approval blocked

This PR was not automatically approved for CI because the security gate failed.

Possible reasons:

  • The PR touches 50 or more files — only PRs with fewer than 50 changed files are automatically approved
  • A changed file is outside the allowed directories (src/, tests/, docs/, utils/), has a disallowed extension (only .py, .txt, .md permitted outside tests/ and docs/), or is not .md/.yml inside docs/ — this covers files the PR deletes or renames, not only the ones it edits
  • A new security issue was detected in the changed Python files (Bandit check) — a high-severity one, shell execution, exec/eval, a URL fetch, or disabled TLS verification
  • The PR touches a path this repository protects from untrusted PRs, such as the file that decides who reviews it — a maintainer must make that change in a separate PR

See the workflow run for the exact violations.

A maintainer can review and manually approve CI if a finding is a false positive.

@hf-security-analysis
hf-security-analysis Bot force-pushed the security/workflow-hardening/pr-49357-design branch from d4d30e2 to 3b62f4b Compare October 13, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants