Repository navigation
[serge] Fix 2 integration tests for model mamba2 failing with output_mismatch (other (2)) - #49945
Open
sergereview[bot] wants to merge 1 commit into
Open
sergereview[bot] wants to merge 1 commit into
sergereview[bot] wants to merge 1 commit into
Conversation
…ut_mismatch` (other (2))
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: mamba2 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original CI failure
2 integration tests for modelmamba2failing withoutput_mismatch(other (2))tests/models/mamba2/test_modeling_mamba2.py::Mamba2IntegrationTest::test_simple_generate[single-gpu] (output_mismatch, seen 21/21)CI traceback —
tests/models/mamba2/test_modeling_mamba2.py::Mamba2IntegrationTest::test_simple_generateWhere to watch it:
The A10G (compute capability 8.6) produces the "written in C++" variant, identical to the existing
("xpu", 3)entry. Without a("cuda", 8)key,Expectationsfalls back to("cuda", 7)(score 1, the only cuda key), which has the "in C++" variant — a stale expectation.Adds a
("cuda", 8)key with the value the runner actually produces. The difference from("cuda", 7)is a single word ("written") in the generated text — normal hardware-level variation for a language model, not a regression.Relates to #49943
This patch changes only expected values in test files — the assertions were rewritten, not the code under test.
The GPU run below is not evidence that this change is correct: the tests were re-run after the patch rewrote what they assert, so they pass by construction. Judge the new value on its merits.
Possibly related
Existing issues/PRs mentioning
test_simple_generate(keyword match — not verified to share a root cause):Kernels] Refactor all linear attn models & native kernels fallback (PR, closed, updated 2026-08-05)This change was produced automatically by serge from a CI failure report. The patch was generated by an LLM and applied by serge; review before merging.
serge
v0.1.0· model:Qwen/Qwen3.8-27B:deepinfra· 14 LLM turns · 13 tool calls · 391.8s · 288606 in / 6105 out tokens