Skip to content

⚰️ Remove deprecated - #3704

Merged
qgallouedec merged 7 commits into
mainfrom
remove-deprecated-5
Jul 22, 2025
Merged

qgallouedec merged 7 commits into
mainfrom
remove-deprecated-5

Conversation

@qgallouedec

Copy link
Copy Markdown
Member

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Comment thread tests/test_sft_trainer.py
formatting_func=formatting_prompts_func,
)

def test_sft_trainer_with_model_num_train_epochs(self):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test removed, not sure what it was testing

Comment thread tests/test_sft_trainer.py

self.assertIsNotNone(trainer.state.log_history[-1]["train_loss"])

def test_with_multiple_eval_datasets(self):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to SFTTrainerTester2

Comment thread tests/test_sft_trainer.py
result_text2 = tokenizer.decode(non_masked_tokens2)
self.assertEqual(result_text2, " I should not be masked. I should not be masked too.")

def test_with_model_neftune(self):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, neftune support support is now in transformers

Comment thread tests/test_sft_trainer.py
self.assertEqual(len(trainer.model.get_input_embeddings()._forward_hooks), 0)

@require_peft
def test_peft_str(self):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to SFTTrainerTester2

Comment thread tests/test_sft_trainer.py
)

@require_peft
def test_peft_sft_trainer(self):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely a duplicate of the above, removed

Comment thread tests/test_sft_trainer.py
self.assertIsNotNone(trainer.state.log_history[-1]["train_loss"])

@require_peft
def test_peft_and_gradient_checkpointing(self):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to SFTTrainerTester2

Comment thread tests/test_sft_trainer.py
self.assertIsNotNone(trainer.state.log_history[-1]["train_loss"])

@require_peft
def test_peft_neftune(self):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, neftune support is now part of transformers

Comment thread tests/test_sft_trainer.py
self.assertEqual(len(trainer.model.get_input_embeddings()._forward_hooks), 0)

@require_peft
def test_peft_tag(self):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to SFTTrainerTester2

Comment thread tests/test_sft_trainer.py
self.assertIn(tag, trainer.model.model_tags)

@require_peft
def test_tag(self):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to SFTTrainerTester2

Comment thread tests/test_sft_trainer.py

self.assertIsNotNone(trainer.state.log_history[-1]["train_loss"])

def test_torch_dtype(self):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to SFTTrainerTester2

@qgallouedec
qgallouedec merged commit e102ac8 into main Jul 22, 2025
@qgallouedec
qgallouedec deleted the remove-deprecated-5 branch July 22, 2025 01:16
@wa008 wa008 mentioned this pull request Jul 29, 2025
5 tasks done
marcandrelarochelle pushed a commit to marcandrelarochelle/trl that referenced this pull request Jul 29, 2025
LuisVasquezBSC pushed a commit to langtech-bsc/trl that referenced this pull request Aug 28, 2025
LuisVasquezBSC pushed a commit to langtech-bsc/trl that referenced this pull request Aug 28, 2025
@qgallouedec qgallouedec mentioned this pull request Jul 12, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants