StackLlama: fixed RL training and added args #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added steps argument and break to respect max training epochs added more PPOConfig args to script args removed llama tokenizer hacks removed extra args in dataset changed to llamatokenizer from autotokenizer black + isort
Closed
Contributor
|
You can use |
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
THank you so much for your contribution! Could you just run the styling checks? After that we should be good for merging
make style && make quality
Contributor
Author
|
Fixed style and quality and Switched back to Autotokenizer, thanks for the tip @ArthurZucker |
lvwerra
approved these changes
Jun 5, 2023
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* fixed rl training args added steps argument and break to respect max training epochs added more PPOConfig args to script args removed llama tokenizer hacks removed extra args in dataset changed to llamatokenizer from autotokenizer black + isort * black and flake8 * style, quality, and switch back to AutoTokenizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added steps argument and break to respect max training epochs added more PPOConfig args to script args
removed llama tokenizer hacks
black + isort
switched toaddedLlamaTokenizerfromAutoTokenizerreturn_token_type_ids=Falseto pipeline kwargs becauseLlamaTokenizerFastLlamaTokenizerFastwill outputtoken_type_idssee LLaMATokenizerFast works abnormally transformers#23818 and 🚨🚨 🚨🚨 [Tokenizer] attemp to fix add_token issues🚨🚨 🚨🚨 transformers#23909token_type_idscause an error in our reward modelpipeline, namelyTypeError: LlamaForSequenceClassification.forward() got an unexpected keyword argument 'token_type_ids'