Repository navigation
[Online-DPO] fix the completion_len == max_new_tokens crash #4193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7359b0f
[Online-DPO] fix the completion_len == max_new_tokens crash
kashif c466b47
prepeare ref_model properly
kashif 1de9563
use prepare_fsdp
kashif 4718e32
Merge branch 'main' into kashif-patch-1
kashif f883a91
Update trl/trainer/online_dpo_trainer.py
kashif 26b967d
Update trl/trainer/online_dpo_trainer.py
kashif 324c768
Merge branch 'main' into kashif-patch-1
kashif 379fc78
Update model weights if needed
kashif c3fd3be
add warning
kashif 7c8bec1
Merge branch 'main' into kashif-patch-1
kashif 9c2508e
Update trl/trainer/online_dpo_config.py
kashif f1c7fea
use warnings
kashif 54c97ad
use same pattern as grpo_trainer
kashif 5b7713f
fix for judges
kashif a2d07aa
Merge branch 'main' into kashif-patch-1
kashif 66213f1
Merge branch 'main' into kashif-patch-1
kashif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.