Repository navigation
Use explicit tiny-Qwen2ForCausalLM-2.5 model_id param in CI tests - #4331
albertvillanova wants to merge 22 commits into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
In my opinion, the numerous repetitions of |
…t-model-id-tiny-qwen2-for-causal-lm
This reverts commit bc12110.
… trainer args tests
…t-model-id-tiny-qwen2-for-causal-lm
|
@qgallouedec, I have addressed your requests and fixed the conflicts. |
…t-model-id-tiny-qwen2-for-causal-lm
|
Thanks, Albert. As I mentioned, I don't think there's much point in parameterizing tests that only use one model anyway (and in most cases we don't want to extend the tests to more models). The motivation is to increase maintainability, but for me it's not clear if it really increases maintainability. |
Use explicit tiny-Qwen2ForCausalLM-2.5 model_id param in CI tests.
This change improves test flexibility and maintainability by allowing tests to easily run with different model IDs. All hardcoded references to the model "trl-internal-testing/tiny-Qwen2ForCausalLM-2.5" have been replaced with the parametrized variable, and the corresponding test function signatures were updated.
No changes were made to the core test logic or assertions; the focus is on improving test parametrization and maintainability.
Follow-up to: