Repository navigation
Remove xfail for Qwen3VL CI tests - #5402
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
The failing test is unrelated. It is caused by flaky CI and I opened a PR to fix it: |
kashif
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove xfail for Qwen3VL CI tests.
After investigation, I found that the bug (huggingface/transformers#43334) never landed on an official release, just in v5.0.0.dev0. It was fixed in v5.0.0 by:
In transformers v5.0.1, the bug was fixed for other models besides
qwen3_vl:glm4v,glm_image,glm_ocr,phi,qwen2_5_omni, andqwen3_vl_moe. However, we don't test these models in our CI. The fixing PR was:pad_token_idtransformers#43453I have tested locally with transformers v5.0.0 and the tests pass.
Follow-up to:
Revert:
Note
Low Risk
Low risk because changes are limited to test markers, but it may surface new CI failures if upstream
transformersregressions reappear in certain versions.Overview
Removes the
pytest.mark.xfailconditions fortrl-internal-testing/tiny-Qwen3VLForConditionalGenerationin the VLM test parametrizations forDPOTrainer,SFTTrainer, andforward_masked_logitsutils tests.As a result, Qwen3-VL now runs as a normal CI test (still
skipif-gated ontransformers>=4.57.0) instead of being treated as an expected failure for specifictransformersversion ranges.Written by Cursor Bugbot for commit 304e22c. This will update automatically on new commits. Configure here.