Skip to content

Remove xfail for Qwen3VL CI tests - #5402

Merged
albertvillanova merged 2 commits into
huggingface:mainfrom
albertvillanova:fu-4842
Mar 31, 2026
Merged

albertvillanova merged 2 commits into
huggingface:mainfrom
albertvillanova:fu-4842

Conversation

@albertvillanova

@albertvillanova albertvillanova commented Mar 30, 2026 •

Copy link
Copy Markdown
Member

Remove xfail for Qwen3VL CI tests.

After investigation, I found that the bug (huggingface/transformers#43334) never landed on an official release, just in v5.0.0.dev0. It was fixed in v5.0.0 by:

In transformers v5.0.1, the bug was fixed for other models besides qwen3_vl: glm4v, glm_image, glm_ocr, phi, qwen2_5_omni, and qwen3_vl_moe. However, we don't test these models in our CI. The fixing PR was:

I have tested locally with transformers v5.0.0 and the tests pass.

Follow-up to:

Revert:


Note

Low Risk
Low risk because changes are limited to test markers, but it may surface new CI failures if upstream transformers regressions reappear in certain versions.

Overview
Removes the pytest.mark.xfail conditions for trl-internal-testing/tiny-Qwen3VLForConditionalGeneration in the VLM test parametrizations for DPOTrainer, SFTTrainer, and forward_masked_logits utils tests.

As a result, Qwen3-VL now runs as a normal CI test (still skipif-gated on transformers>=4.57.0) instead of being treated as an expected failure for specific transformers version ranges.

Written by Cursor Bugbot for commit 304e22c. This will update automatically on new commits. Configure here.

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova

Copy link
Copy Markdown
Member Author

The failing test is unrelated. It is caused by flaky CI and I opened a PR to fix it:

@albertvillanova
albertvillanova merged commit 2e5a5b6 into huggingface:main Mar 31, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants