Repository navigation
Remove the experimental XPO trainer - #7256
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Sep 18, 2026
This was referenced Sep 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
trl.experimental.xpo(XPOTrainer,XPOConfig), added in #1943 and moved totrl.experimentalin #4485.Motivation
Reporting the inputs discussed in #7182:
xpoandtrltags, none created this year. Nobody has spoken up for it in [RFC] Criteria for removing code fromtrl.experimental#7182.XPOTraineris imported by no major training framework.trl.experimentalsince 2025-11-06, deprecated import path dropped 2026-02-10. Long enough to have been found.Solution
trl.experimentalcarries no stability guarantee, so there is no deprecation cycle. The code stays in the git history.The paper index entry stays and points at the last release that shipped the implementation, following the discussion in #7182.
Changes
XPOTrainer,XPOConfigand their testsXPOTrainerfrom the telemetry allowlistNote
Medium Risk
Removes a public experimental API and training capability with no in-library substitute, which will break any remaining
trl.experimental.xpoimports after upgrade.Overview
Removes the experimental Exploratory Preference Optimization stack (
trl.experimental.xpo:XPOTrainer,XPOConfig), its tests, and the dedicatedxpo_trainerdoc page.Documentation and integration guides no longer list XPO: experimental toctree, main trainer index, dataset-format compatibility table, and all vLLM examples/options for XPO are dropped. The paper index entry for XPO remains but now states the trainer shipped through v1.13 and lives only in git history (the
XPOConfigusage snippet is removed).XPOTraineris also removed from the telemetry trainer allowlist inbase_trainer.py.There is no replacement trainer for exploratory preference optimization in this change—callers must pin an older TRL release or recover the code from history.
Reviewed by Cursor Bugbot for commit 34985a8. Bugbot is set up for automated code reviews on this repo. Configure here.