Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
dnechay
requested review from
Dzeranov and
portuu3
and removed request for
portuu3
portuu3
approved these changes
Feb 20, 2025
This was referenced Feb 21, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
N/A
Context behind the change
We got an error from "Dependency Review" check about
parse-durationpackage vulnerability. In order to fix that we can't just use resolutions because fix is in major version, so we need to bump parent package -@graphprotocol/graph-cli- and that requires to use Node@20Taking into account that Node@18 is not LTS anymore starting April 2025, decided to switch to current LTS - 22.
Also in scope of this PR fixed other resolutions to use proper versions of packages in lock file: previously we were skipping some major release for fixes, which is not correct and might have implicit issues.
How has this been tested?
NODE_VERSIONfor staging services on Render and rebuild + deploy, make sure they keep working finescripts/cvatdocker setup locally, make sure it's working e2eRelease plan
NODE_VERSIONon Render StagingNODE_VERSIONon Render ProductionPotential risks; What to monitor; Rollback plan
That something is missing in release plan for specific env. We should notice it during the build phase since we have packages that require Node@20 now so
yarn installwill fail if invalid Node version provided. As a solution - provide the correct one