Use variable velocity when playing sample when clicking on instrument list

[elpescado]

Currently, clicking on instrument name on instrument list plays sample of that instrument with constant velocity = 0.8. This patch makes velocity depend on click position, with velocity rising from left to right.

[mauser]

Hi!

That's a neat idea. But at the moment i'm not sure about the usability: Will people understand why the instrument preview is louder if they click on the right side of the label? Or will they be just irritated?

It would be nice to have more opinions on this topic!

[thijz]

some ideas

1. single-click could be the existing behavior and double click this enhanced behavior ?
2. hovering over the instrument name could show a tooltip 'clik to preview sample at velocity X' that updates when you move over the instrument name
3. the background color of the instrument name area can change when you move over it left to right giving you visual feedback of the velocity

[elpescado]

That's a neat idea. But at the moment i'm not sure about the usability: Will people understand why the instrument preview is louder if they click on the right side of the label? Or will they be just irritated?

I think users will quickly discover relation between note velocity and click position. Moreover I have seen this in other applications eg. Steven Slate Drums

1. single-click could be the existing behavior and double click this enhanced behavior ?

I don't think that's good idea - I'd expect double click to play sample two times

[thijz]

I don't think that's good idea - I'd expect double click to play sample two times

yep, you're right

[trebmuh]

Great little improvement. I've been testing it and I must say that I love it, thanks!

1. single-click could be the existing behavior and double click this enhanced behavior ?

doesn't seem to be really understandable. -1 here.

2. hovering over the instrument name could show a tooltip 'clik to preview sample at velocity X' that updates when you move over the instrument name

yes, great idea. +1 here.

3. the background color of the instrument name area can change when you move over it left to right giving you visual feedback of the velocity

could be something like that, a kind of visual feedback. +1 here

Hope that helps

[trebmuh]

Could I suggest to add the same behavior when playing a sample from the sound library?

[mauser]

Merged, thanks a lot!

About the tooltip: At the moment i'm biased. One would activate that tool tip quite often, so i dont' know if it would be more annoying or helpful.

[trebmuh]

@mauser : is it really merged into master ? I built from ff19658 and it doesn't seems to be there.

[elpescado]

My github says:

Closed with unmerged commits

This pull request is closed, but the elpescado:feature/instrument_list_velocity branch has unmerged commits.

[mauser]

Sorry, should be fixed now!

[trebmuh]

@mauser and @elpescado : rebuild from a fresh 3002477 and the functionality is here and is working as expected. Thanks !

Added here : https://github.com/hydrogen-music/hydrogen/wiki/New-features-in-Hydrogen-1.0