Skip to content

Conversation

@pvint
Copy link
Contributor

@pvint pvint commented Nov 22, 2016

For Issue #11
snapshot31

@mauser mauser merged commit b9b38fd into master Nov 22, 2016
@mauser
Copy link
Member

mauser commented Nov 22, 2016

Perfect, merged!

@trebmuh
Copy link
Member

trebmuh commented Nov 22, 2016

@trebmuh
Copy link
Member

trebmuh commented Nov 22, 2016

Fresh rebuild from c59eb82 tested, everything is working fine.

@pvint
Copy link
Contributor Author

pvint commented Nov 22, 2016

👍 Thanks for the test @trebmuh

@pvint pvint deleted the instrumentRename_11 branch November 22, 2016 23:54
@trebmuh
Copy link
Member

trebmuh commented Nov 23, 2016

You're really welcome.

I don't really know why but it sounds more logical to me to put the "Rename Instrument" item above the "Delete instrument"'s one. If you find this idea useful, great. If not, just drop this message/idea, that's not a big deal :)

@pvint
Copy link
Contributor Author

pvint commented Nov 24, 2016

I agree, @trebmuh - changed and pushed :)

@trebmuh
Copy link
Member

trebmuh commented Nov 24, 2016

Great! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants