This repository was archived by the owner on Jun 4, 2026. It is now read-only.
Repository navigation
fix(security): refuse shell execution when sandbox disabled, remove local fallback - #76
Merged
Merged
Conversation
…ocal fallback When sandbox_enabled=False, shell_exec now returns a hard refusal instead of falling back to direct execution in the backend container. The local execution fallback (_exec_local) was a security bypass — it ran arbitrary commands inside the backend process with no isolation. Changes: - Remove _exec_local() entirely (no remaining callers) - Return "Shell execution is not available: sandbox is disabled." when sandbox_enabled=False, with a structured warning log event - Update comment: _BLOCKED_PATTERNS is a pre-filter, not a fallback guard - Add case-insensitive bypass tests (RM -RF /, MkFs) — already handled correctly by cmd_lower normalization - Remove test_shell.py (duplicate of test_shell_tool.py, fully covered) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🤖 Hi @hyhmrright, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
github-actions
Bot
added
documentation
|
🤖 I'm sorry @hyhmrright, but I was unable to process your request. Please see the logs for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code