Skip to content

Conversation

@yxnan
Copy link
Contributor

@yxnan yxnan commented Oct 26, 2022

Description

The color code should not be emitted if the stdout is not a typical terminal, we add the check so there is no need to explictly specify --stdout

Issues

p-e-w/shin#3 (comment)

The color code should not be emitted if the stdout is not a typical terminal, we add the check so there is no need to explictly specify `--stdout`
@yxnan
Copy link
Contributor Author

yxnan commented Oct 27, 2022

I think changing how the --stdout option works can have both feet on the ground. By having 3 possible values rather than a simple switch, we can choose to let the program decide itself or specify a value we want.

Despite having changed the default config, users who keep the older configs can still expect the program works exactly as before.

@hykilpikonna
Copy link
Owner

I think changing how the --stdout option works can have both feet on the ground. By having 3 possible values rather than a simple switch, we can choose to let the program decide itself or specify a value we want.

Despite having changed the default config, users who keep the older configs can still expect the program works exactly as before.

That's a nice solution, thank you so much!

@hykilpikonna hykilpikonna merged commit 90c9404 into hykilpikonna:master Oct 27, 2022
teohhanhui added a commit to teohhanhui/hyfetch that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants