🌈 Support custom ASCII art file path #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the pr! At first glance there are some things I want to change but don't have time right now due to a submission deadline… will do that later |
hykilpikonna
approved these changes
Oct 1, 2025
hykilpikonna
approved these changes
Oct 1, 2025
Owner
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows users to specify a custom ASCII art file path in their config or during first time setup and validates if it is a valid path. This means users no longer have to set up an alias to run the command with --ascii-file which should improve user experience.
Relevant Links
Issue 104
Pull 427
Screenshots
Additional context
These changes have been made to the rust & to the python versions of these projects