Fix git check for windows #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2023 17:44
…s without git installed via the git-for-windows installer.
Author
|
Fixes #83, Confirmed working |
hykilpikonna
approved these changes
Feb 7, 2023
Owner
|
Thanks, that should work! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix git path being hard-coded on windows.
Also added a vs-code debugging profile for others to not go in the same route as me: trying to debug while vscode's debugger runs everything from the wrong directory.
Features
Disable HyFetch's requirement of git installed from the "GitForWindows" website. (https://gitforwindows.org/)
Issues
None AFAIK, Don't know if this works with the GitForWindows version of git yet, but i assume it does due to my un-obtrusive code additions.
TODO
Verify compatibility with GitForWindows.