Use the new Bionic module from Swift 6 where possible #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, keep force unwrap for non-Android in `FileHandle._readDataOfLength()` and remove wrong `guard` for Android in `Process.run()`.
finagolfin
commented
Aug 11, 2024
| @@ -932,13 +932,6 @@ open class Process: NSObject, @unchecked Sendable { | |||
| var spawnAttrs: posix_spawnattr_t? = nil | |||
| #else | |||
| var spawnAttrs: posix_spawnattr_t = posix_spawnattr_t() | |||
| #endif | |||
| #if os(Android) | |||
| guard var spawnAttrs else { | |||
There was a problem hiding this comment.
I don't know what the point of this is, as it's set to nil just a couple lines above and fails to compile with NDK 26.
This was referenced Aug 11, 2024
|
Closing since the upstream pull seems to be abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, keep force unwrap for non-Android in
FileHandle._readDataOfLength()and remove wrongguardfor Android inProcess.run().