Skip to content

Conversation

@severo
Copy link
Contributor

@severo severo commented Dec 12, 2025

see #241

@severo severo force-pushed the 241-fix-scroll-for-big-datasets branch from f2ac1db to 6c334b8 Compare December 16, 2025 17:30
@severo
Copy link
Contributor Author

severo commented Dec 16, 2025

fyi @platypii:

it works :)

Screencast.From.2025-12-17.00-32-10.mp4

As you see, still a detail with the first cell being below the header in some configurations. I'll fix it tomorrow.

BUT, I just discovered that we also have to handle the horizontal scroll (we cannot focus the cell horizontally without also scrolling vertically, which breaks the virtual scroll)

Screencast.From.2025-12-17.00-35-35.mp4

After doing the horizontal scrolling, I think we will be able to test manually to ensure it's usable as expected, and I'll add unit tests...

@severo severo closed this Dec 16, 2025
@severo severo reopened this Dec 16, 2025
@severo
Copy link
Contributor Author

severo commented Dec 16, 2025

^ accidental click on "Close with comment"

@severo
Copy link
Contributor Author

severo commented Dec 18, 2025

Tasks:

  • under a threshold (< 17M pixels, first limit with Firefox), don't use a virtual domain, just use the scroll, as before
  • above the threshold, handle better some details:
    • change in the number of rows
    • use a non-linear scroll? if the scroll gesture is less than a threshold (5% of the scrollbar height), consider it local, otherwise, global

@severo severo force-pushed the 241-fix-scroll-for-big-datasets branch 4 times, most recently from 32343ba to 1797ab9 Compare December 18, 2025 18:29
@severo severo force-pushed the 241-fix-scroll-for-big-datasets branch from 1797ab9 to c92126b Compare December 18, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants