fix: do not multithread ChatMessage processing #861
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat messages must be processed before the packet bump allocator is cleared because they store a reference to the packet data. In other words, we need a happens-before relationship where chat message processing happens before the packet bump allocator is cleared. Disabling multithreaded ChatMessage processing is one way of providing this happens-before relationship, and since processing chat messages is relatively cheap, this should not cause any noticable performance problems.