Skip to content

feat(service): Add Layered service to propagate NamedService implementation #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

feat(service): Add Layered service to propagate NamedService implementation #1966

merged 1 commit into from
Oct 3, 2024

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Oct 1, 2024 •
edited
Loading

Adds Layered service to propagate NamedService implementation.

Resolves #1958.

@tottoto
Copy link
Collaborator Author

tottoto commented Oct 1, 2024

@mrmeku Does this meet your requirements?

djc
djc reviewed Oct 1, 2024
View reviewed changes
@mrmeku
Copy link

mrmeku commented Oct 1, 2024

@mrmeku Does this meet your requirements?

Absolutely. Great solution

@tottoto
Copy link
Collaborator Author

tottoto commented Oct 2, 2024

@mrmeku Thanks for confirming.

@tottoto tottoto force-pushed the add-layered-service branch from c9b556a to 28cd1e9 Compare October 2, 2024 10:27
@tottoto
Copy link
Collaborator Author

tottoto commented Oct 2, 2024

Added a test.

@tottoto tottoto force-pushed the add-layered-service branch from 5320842 to 2623211 Compare October 2, 2024 23:21
@tottoto tottoto changed the title feat: Add Layered service to propagate NamedService implementation feat(service): Add Layered service to propagate NamedService implementation Oct 2, 2024
@tottoto tottoto force-pushed the add-layered-service branch from 2623211 to a7057fa Compare October 3, 2024 03:55
@tottoto tottoto force-pushed the add-layered-service branch from a7057fa to cdc3034 Compare October 3, 2024 08:41
@tottoto
Copy link
Collaborator Author

tottoto commented Oct 3, 2024

Squashed the commits.

@tottoto tottoto force-pushed the add-layered-service branch from cdc3034 to f18f8a7 Compare October 3, 2024 08:42
@tottoto tottoto added this pull request to the merge queue Oct 3, 2024
Merged via the queue into hyperium:master with commit 9b74abf Oct 3, 2024
17 checks passed
@tottoto tottoto deleted the add-layered-service branch October 3, 2024 22:58
@arthurgubaidullin arthurgubaidullin mentioned this pull request Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tottoto @mrmeku @djc