fix: use exisitng priv key for certs renewal when using vault#286
Merged
adityajoshi12 merged 1 commit intohyperledger-bevel:mainfrom Oct 23, 2025
Merged
Conversation
Signed-off-by: Aditya Joshi <adityaprakashjoshi1@gmail.com>
adityajoshi12
force-pushed
the
channel-pki
branch
from
afbf9f4 to
0ac5416
Compare
Contributor
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using Vault as a PKI, the current certificate reenrollment process uses the
issueAPI to generate new certificates. However, this approach creates a completely new key pair (public and private keys) each time a certificate is renewed.This change updates the reenrollment logic to instead use the
signAPI, which allows Vault to sign an existing CSR (Certificate Signing Request). This enables the system to reuse the existing private key while generating a new certificate.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation, usage docs, etc.: