feat(agent): changes required for issue credential and presentation proof to work #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a test suit to make sure crypto suit is on pair with 1.4
…roof to work fixes ATL-3094
goncalo-frade-iohk
force-pushed
the
feature/ATL-3097
branch
from
de78fcf to
87fbb62
Compare
hamada147
approved these changes
Mar 20, 2023
| } | ||
|
|
||
| // TODO: This function is not the most appropriate but will do the job now to change later. | ||
| private func findValue(forKey key: String, in json: Any) -> String? { |
There was a problem hiding this comment.
Shouldn't this chanege from private to fileprivate
Suggested change
| private func findValue(forKey key: String, in json: Any) -> String? { | |
| fileprivate func findValue(forKey key: String, in json: Any) -> String? { |
| } | ||
|
|
||
| // TODO: This function is not the most appropriate but will do the job now to change later. | ||
| private func findValue(forKey key: String, in json: Any) -> String? { |
There was a problem hiding this comment.
I understand the need for duplication for this function, but shouldn't this change from private to fileprivate
Suggested change
| private func findValue(forKey key: String, in json: Any) -> String? { | |
| fileprivate func findValue(forKey key: String, in json: Any) -> String? { |
There was a problem hiding this comment.
Not really fileprivate is more for when you got private code inside of class and you want to access it lets say in an extension of that class in the same file. With private that would not be possible.
This is a func outside of any class/struct fileprivate would not add anything more. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.