Skip to content

fix: removing rxdb from our main bundle, linting and test improvements #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 21, 2025

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented May 18, 2025

Description:

The previous RXDB module is now located in trust0/identus-store-rxdb which contains its own tests already, extracted from this repo to make sure things will work.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@elribonazo elribonazo requested a review from a team as a code owner May 18, 2025 11:46
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@elribonazo elribonazo marked this pull request as draft May 18, 2025 11:49
@robertocarvajal
Copy link
Contributor

I got confused due to the version is pointing to 6.5.1 and we are at 6.6.0 but it seems like latest release did not updated the package.json version.

The main concern for me now is that SDK.Store is no longer available and all examples break because of that, I think previously it was exporting the rxdb Store implementation as the type, we should review that and try to get the demo app working with this change.

…y tests to @trust0/identus-store-rxdb

Signed-off-by: Roberto Carvajal <[email protected]>
@robertocarvajal
Copy link
Contributor

OK, I updated the tests so they don't break so much with this update, I do think we should update the demo to support ridb at some point, maybe we should move the next demo to something like next-rxdb and make it use the legacy library and then copying that as a starting point for an updated demo with next-ridb implementation.

…h we should move away from

Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@elribonazo elribonazo marked this pull request as ready for review May 21, 2025 12:20
@elribonazo
Copy link
Contributor Author

problem with version i agree its a bug, but it extracts the version through the tag so as soon as the tag is there it will pick up the right next version

Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@elribonazo elribonazo changed the title fix: removing rxdb from our main bundle fix: removing rxdb from our main bundle, linting and test improvements May 21, 2025
@coveralls
Copy link

coveralls commented May 21, 2025

Pull Request Test Coverage Report for Build 15166804938

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 12 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.5%) to 75.951%

Files with Coverage Reduction New Missed Lines %
src/edge-agent/connections/ConnectionsManager.ts 1 62.07%
src/pluto/models/Credential.ts 10 46.88%
Totals Coverage Status
Change from base Build 15064932998: -0.5%
Covered Lines: 3169
Relevant Lines: 3983

💛 - Coveralls

@elribonazo
Copy link
Contributor Author

GOSH! 0.6% decrease, what does that mean and how is that possible, mostly removed stuff.

I will invest time at some point this week to increase coverage or leave it at least with no change.

Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@elribonazo elribonazo merged commit 79c5953 into main May 21, 2025
7 checks passed
@elribonazo elribonazo deleted the rxdb-deprecate branch May 21, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants