-
Notifications
You must be signed in to change notification settings - Fork 17
fix: removing rxdb from our main bundle, linting and test improvements #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
03d0ea1
to
3aa34c4
Compare
I got confused due to the version is pointing to The main concern for me now is that SDK.Store is no longer available and all examples break because of that, I think previously it was exporting the rxdb Store implementation as the type, we should review that and try to get the demo app working with this change. |
…y tests to @trust0/identus-store-rxdb Signed-off-by: Roberto Carvajal <[email protected]>
OK, I updated the tests so they don't break so much with this update, I do think we should update the demo to support ridb at some point, maybe we should move the |
…h we should move away from Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
problem with version i agree its a bug, but it extracts the version through the tag so as soon as the tag is there it will pick up the right next version |
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
7ff4afe
to
473be79
Compare
Pull Request Test Coverage Report for Build 15166804938Details
💛 - Coveralls |
GOSH! 0.6% decrease, what does that mean and how is that possible, mostly removed stuff. I will invest time at some point this week to increase coverage or leave it at least with no change. |
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Description:
The previous RXDB module is now located in trust0/identus-store-rxdb which contains its own tests already, extracted from this repo to make sure things will work.
Checklist: