Skip to content

test: vitest config properly loading wasm modules #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

robertocarvajal
Copy link
Contributor

Description:

Fixes loading wasm modules on vitest, allowing all tests to run/pass

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@robertocarvajal robertocarvajal requested a review from a team as a code owner May 21, 2025 02:46
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15152342099

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.451%

Totals Coverage Status
Change from base Build 15064932998: 0.0%
Covered Lines: 3337
Relevant Lines: 4163

💛 - Coveralls

@elribonazo
Copy link
Contributor

Not sure I follow but are tests not passing? they do right

@elribonazo
Copy link
Contributor

Don't think thats needed buddy, https://github.com/hyperledger-identus/sdk-ts/actions/runs/14976235091/job/42069185661#step:16:28

tests are running wasm correctly, not sure why u need this and if its more related to your env or what, let's talk about it

@elribonazo
Copy link
Contributor

I see they are needed in my pluto PR but not here def, close this plz :) let's deal in other PR

@robertocarvajal
Copy link
Contributor Author

that's weird because when I pulled from main they were definitely needed, I'll close this one but will check on next merge if it's still needed, it's an easy fix so might be useful for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants