Skip to content

fix(js): add missing type #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swcurran merged 1 commit into from
Feb 13, 2024
Merged

fix(js): add missing type #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions wrappers/javascript/indy-vdr-nodejs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,11 @@
"typescript": "~4.9.4"
},
"dependencies": {
"@hyperledger/indy-vdr-shared": "0.2.0-dev.6",
"@mapbox/node-pre-gyp": "^1.0.10",
"@2060.io/ffi-napi": "4.0.8",
"@2060.io/ref-napi": "3.0.6",
"@hyperledger/indy-vdr-shared": "0.2.0-dev.6",
"@mapbox/node-pre-gyp": "^1.0.10",
"@types/ref-array-di": "^1.2.8",
Copy link
Contributor

@genaris genaris Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was about the @types/ref-array-di, @mapbox/node-pre-gyp or both?

For the first one I think I'll probably need to add it to @2060.io/ffi-napi dependencies

Copy link
Contributor Author

@TimoGlastra TimoGlastra Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for @types/ref-array-di, the other ones are just reordered in the list. Adding them to @2060.io/ffi-napi might work, but I think the error was coming from indy-vdr

"ref-array-di": "^1.2.2",
"ref-struct-di": "^1.1.1"
},
Expand Down
8 changes: 4 additions & 4 deletions wrappers/javascript/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2013,10 +2013,10 @@
"@types/scheduler" "*"
csstype "^3.0.2"

"@types/ref-array-di@^1.2.5":
version "1.2.5"
resolved "https://registry.yarnpkg.com/@types/ref-array-di/-/ref-array-di-1.2.5.tgz#822b9be5b934398fafd5c26264d8de80d487747d"
integrity sha512-dA/Himb7ca/Tf5vqLOhi7LewAAoOXghlocw7gAqvNrmLybAtu+w2BLzEsbFWAtx5ElNzMEHDaRybueYViFROjQ==
"@types/ref-array-di@^1.2.8":
version "1.2.8"
resolved "https://registry.yarnpkg.com/@types/ref-array-di/-/ref-array-di-1.2.8.tgz#2b44567b8eaae72c59db68a482f5d26297e955be"
integrity sha512-+re5xrhRXDUR3sicMvN9N3C+6mklq5kd7FkN3ciRWio3BAvUDh2OEUTTG+619r10dqc6de25LIDtgpHtXCKGbA==
dependencies:
"@types/ref-napi" "*"

Expand Down