Skip to content

Conversation

@andrewwhitehead
Copy link
Contributor

No description provided.

@swcurran
Copy link
Contributor

I gather this didn’t fix the issue?

@cvarjao
Copy link
Contributor

cvarjao commented May 27, 2024

Switching to macos-12 get us back to a working pipeline. Maybe in a separate PR, we should still review compatibility with macos 14.

Changes:
https://github.com/hyperledger/indy-vdr/compare/main...cvarjao-o:indy-vdr:fix-cd?expand=1

Execution:
https://github.com/cvarjao-o/indy-vdr/actions/runs/9259858312

XCode
MacOS 12 Runner: https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md
MacOS 14 Runner: https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md

@andrewwhitehead
Copy link
Contributor Author

Pinning cc to 1.0.83 seems to help the Darwin build on 14.x. I'm not sure if the exact issue has been reported but there are some potentially related cross compilation issues.

There's still an error in the iOS build occurring with cc pinned. In particular, this command seems to mix different architectures:

/usr/bin/clang -fPIC --target=x86_64-apple-ios -m64 -mios-simulator-version-min=7.0 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk -fembed-bitcode -arch arm64 -MD -MT CMakeFiles/cmTC_e5ae3.dir/testCCompiler.c.o -MF CMakeFiles/cmTC_e5ae3.dir/testCCompiler.c.o.d -o CMakeFiles/cmTC_e5ae3.dir/testCCompiler.c.o -c /Users/runner/work/indy-vdr/indy-vdr/target/x86_64-apple-ios/release/build/zmq-sys-cb80815203982fd7/out/build/CMakeFiles/CMakeScratch/TryCompile-YFxGth/testCCompiler.c

I'm going to limit this PR to just fixing the minor version detection issue in build-universal.sh.

@andrewwhitehead
Copy link
Contributor Author

@cvarjao Could you create a PR for your changes

@cvarjao
Copy link
Contributor

cvarjao commented May 27, 2024

Sure thing, here it is:

Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead andrewwhitehead merged commit 9d43f97 into hyperledger-indy:main May 27, 2024
@andrewwhitehead andrewwhitehead deleted the fix/darwin-build branch May 27, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants