Transform SQL queries to parameterized queries [BE-833] #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…[BE-833] Signed-off-by: sigma67 <[email protected]>
sigma67
requested review from
JeevaSang,
nekia,
nfrunza,
vchinoy-da and
xspeedcruiser
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
nekia
approved these changes
Oct 6, 2020
|
P.S. Currently unit test suite for API server side doesn't work. So we need to reconstruct it asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in BE-833. This fixes all SQL injection attack vectors I could find. Let me know if I missed any queries.
It makes the code a bit more readable as well (in my opinion).
Signed-off-by: sigma67 [email protected]