BE-834 Fix memory leak issue of sync process #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to keep a discovery service instance after initializing it at the boot phase. Signed-off-by: Atsushi Neki <[email protected]>
Signed-off-by: Atsushi Neki <[email protected]>
Signed-off-by: Atsushi Neki <[email protected]>
nekia
requested review from
JeevaSang,
nfrunza,
vchinoy-da and
xspeedcruiser
as code owners
nekia
changed the title
nekia
force-pushed
the
be-834-memory-leak
branch
from
e4d191d to
2835570
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
JeevaSang
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.hyperledger.org/browse/BE-834
Also recreated a new unit test suite for server backend (FabricGateway.ts)
We can run the unit test with the following: