added pagination for transactions view frontend #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has dependency on #346 |
|
LGMT, please squash the commits. |
| "react-copy-to-clipboard": "^5.0.1", | ||
| "react-d3-graph": "^1.0.1", | ||
| "react-datepicker": "^1.6.0", | ||
| "react-dom": "^16.2.0", |
There was a problem hiding this comment.
mui has dependency on recent versions of react
| componentWillUnmount() { | ||
| clearInterval(this.interVal); | ||
| clearInterval(this.interval); | ||
| if (this.props.transactionId) { |
There was a problem hiding this comment.
resolved - interval not getting cleared on unmount in existing code. Please review the latest commits @adityajoshi12
Signed-off-by: deekshithvarma256 <[email protected]>
deekshithvarma256
force-pushed
the
BE-347
branch
from
2722106 to
639ef23
Compare
adityajoshi12
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: deekshithvarma256 [email protected]
What this PR does / why we need it:
This feature integrates the Api calls to render server-side pagination for list of transactions to be fetched.
As of now the pagination is being handled from UI. Implementing pagination from backend addresses an issue when dealing with retrieval of huge data sets.
Which issue(s) this PR fixes:
Fixes #347
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation, usage docs, etc.: