Empty org is being displayed while fetching the list of orgs #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArchanaArige <[email protected]>
| @@ -701,7 +701,7 @@ export class MetricService { | |||
| getTxByOrgs(network_name: any, channel_genesis_hash: any) { | |||
| const sqlPerOrg = ` select count(creator_msp_id), creator_msp_id | |||
| from transactions | |||
| where channel_genesis_hash =$1 and network_name=$2 | |||
| where Trim(creator_msp_id) > '' and channel_genesis_hash =$1 and network_name=$2 | |||
There was a problem hiding this comment.
[nitpick]: how about using not equal operator <>.
There was a problem hiding this comment.
yes we can use not equal but in order to handle the case trailing spaces along with empty fields used "TRIM" function.
adityajoshi12
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Test the Explorer compatibility with Hyperledger Fabric v2.4.7.
The functionality which fetches the list of orgs, is also fetching an empty org. This is due to the reason that the first transaction of type "config" is not associated with any creator organisation. So, while saving this transaction to the postgres, the field creator_msp_id is blank.
Which issue(s) this PR fixes:
Fixes #372
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation, usage docs, etc.: