Add support for extended logging in DbConfig #1003
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Signed-off-by: bar haim <[email protected]>
Signed-off-by: bar haim <[email protected]>
barvhaim
force-pushed
the
999-postgres-config-support-for-extended-logging
branch
from
5e85a4c to
f7256e3
Compare
Signed-off-by: bar haim <[email protected]>
| cli, err := client.NewClientWithOpts(client.FromEnv, client.WithAPIVersionNegotiation()) | ||
| require.NoError(t, err) | ||
|
|
||
| ctx := context.Background() |
There was a problem hiding this comment.
you can use t.Context() as this allows the test harness to cancel the context and all probably all consumers of the context.
| // Check extended logging parameters based on expectation | ||
| cmd := inspect.Config.Cmd | ||
| if expectExtendedLogging { | ||
| assert.Contains(t, cmd, "log_destination=stderr") |
There was a problem hiding this comment.
I am wondering if there is a particular reason to use assert over require here. The difference is that assert does not call FailNow.
|
|
||
| // Add extended logging configuration if enabled | ||
| if c.ExtendedLogging { | ||
| containerConfig.Cmd = []string{ |
There was a problem hiding this comment.
The ExtendedLogging toggle probably makes sense for many cases and I can imagine that when debugging with postgres, sometimes more flexibility is needed when investigating an odd issue.
I think it would be nice to allow the Cmd be overwritten via env vars to let the user inject any postgres command / env vars via testing without touching this code all the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.