Clean up logging #986
Merged
Clean up logging #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
requested changes
Jul 15, 2025
| @@ -110,7 +110,7 @@ func (c *FinalityManager[V]) runStatusListener(ctx context.Context) { | |||
| c.logger.Debugf("check vault status for [%d] transactions", len(txIDs)) | |||
| statuses, err := c.vault.Statuses(newCtx, txIDs...) | |||
| if err != nil { | |||
| c.logger.Errorf("error fetching statuses: %w", err) | |||
| c.logger.Errorf("error fetching statuses: %s", err.Error()) | |||
There was a problem hiding this comment.
please, Arne, while updating these logs, check also if a context.Context is available and in case, use the context logger. In this case, it would be ErrorfContext(ctx,...
This, in addition to writing a log, will also generate an event in the traces.
Please, make sure that the string printed is printable. Arguments might need to sanitized depending on the cases.
| @@ -56,7 +56,7 @@ func (db *SimpleKeyDataStore) PutData(ctx context.Context, key string, data []by | |||
| Row(key, data). | |||
| OnConflictDoNothing(). | |||
| Format() | |||
| logger.Debug(query, params) | |||
| logger.Debug(query, string(data)) | |||
There was a problem hiding this comment.
in this case, we don't need the DebugfContext because an event in the trace will be added by the call to ExecContext later.
Closed
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Arne Rutjes <[email protected]>
Signed-off-by: Arne Rutjes <[email protected]>
Signed-off-by: Arne Rutjes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #981