Skip to content

Moved jaeger/prometheus check logic into reporters and added iterator… #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2025
Merged

Moved jaeger/prometheus check logic into reporters and added iterator… #997

merged 1 commit into from
Jul 27, 2025

Conversation

alexandrosfilios
Copy link
Contributor

… utils

@alexandrosfilios alexandrosfilios requested a review from adecaro July 23, 2025 11:16
@adecaro
Copy link
Contributor

adecaro commented Jul 24, 2025

@alexandrosfilios , please:

  • Fill the metadata on the right-hand side of this page
  • Add a proper title and comment to the PR
  • Add comments and unit-tests to the code
    Thanks much

@adecaro adecaro self-assigned this Jul 27, 2025
@adecaro adecaro added NWO All about our testing infrastructure monitoring labels Jul 27, 2025
@adecaro adecaro added this to the Q3 milestone Jul 27, 2025
adecaro
adecaro approved these changes Jul 27, 2025
View reviewed changes
Copy link
Contributor

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adecaro adecaro merged commit 0ff2d27 into main Jul 27, 2025
18 checks passed
@adecaro adecaro deleted the f-jaeger branch July 27, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecaro adecaro adecaro approved these changes

Assignees

@adecaro adecaro

Labels
monitoring NWO All about our testing infrastructure
Projects
None yet
Milestone
Q3
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandrosfilios @adecaro