Extend PeerRejectedProposalError for rejected updates#11
Merged
ggwpez merged 2 commits intohyperledger-labs:devfrom Mar 11, 2021
Merged
Conversation
manoranjith
force-pushed
the
named-errors-peer-rejected-update
branch
7 times, most recently
from
be03ae0 to
f878155
Compare
manoranjith
changed the title
added 2 commits
March 10, 2021 20:13
- So that the same error type can be used when peer rejects an update or a proposal.. Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
manoranjith
force-pushed
the
named-errors-peer-rejected-update
branch
from
f878155 to
fc4bafb
Compare
ggwpez
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have renamed
PeerRejectedProposalErrortoPeerRejectedError, so that the same error type can be used when peer rejects an update as well.The other option could be to use two error types. Request your feedback on this.