Prepare 82 virtual channels#114
Merged
ggwpez merged 9 commits intohyperledger-labs:devfrom Jun 22, 2021
Merged
Conversation
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
prepare-82-virtual-channels
branch
from
a0d0c65 to
ea250c2
Compare
ggwpez
reviewed
Jun 19, 2021
Contributor
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
The commit structure makes it easy to follow 👍
Signed-off-by: Matthias Geihs <matthias@perun.network>
This enables the framework to distinguish between standard channel update messages and funding or settlement update messages. Signed-off-by: Matthias Geihs <matthias@perun.network>
Because it contains not just watching, but also registering, progressing, and settling. Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
prepare-82-virtual-channels
branch
from
ea250c2 to
c05d177
Compare
ggwpez
approved these changes
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting some commits from #83 .